Announce: OpenSSH 5.8 released

[Andreas M. Kirchwitz]

Damien Miller <djm at cvs.openbsd.org> wrote:

 > Portable OpenSSH Bugfixes:
 >
 >  * Fix compilation failure when enableing SELinux support.
 >
 >  * Do not attempt to call SELinux functions when SELinux is disabled.
 >    bz#1851
 
Thanks for fixing this. Unfortunately, it went wrong somehow.
If configured on Linux (Fedora 14) with SELinux, compilation fails:

gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wno-pointer-sign -Wno-unused-result -fno-strict-aliasing -fno-builtin-memset -fstack-protector-all  -I. -I.. -I. -I./.. -I/usr/local/ssl/include  -DHAVE_CONFIG_H -c port-linux.c
port-linux.c: In function ‘ssh_selinux_setfscreatecon’:
port-linux.c:212:21: warning: unused variable ‘context’
port-linux.c: At top level:
port-linux.c:220:2: error: expected identifier or ‘(’ before ‘if’
port-linux.c:222:1: error: expected identifier or ‘(’ before ‘}’ token
make[1]: *** [port-linux.o] Error 1
make[1]: Leaving directory `/usr/local/src/openssh-5.8p1/openbsd-compat'
make: *** [openbsd-compat/libopenbsd-compat.a] Error 2


This patch fixes the problem:

--- ./openbsd-compat/port-linux.c_orig  2011-02-04 01:43:08.000000000 +0100
+++ ./openbsd-compat/port-linux.c       2011-02-04 03:06:21.060012941 +0100
@@ -213,7 +213,7 @@
 
        if (!ssh_selinux_enabled())
                return;
-       if (path == NULL)
+       if (path == NULL) {
                setfscreatecon(NULL);
                return;
        }


I really hope that you don't hate me for all this Linux weirdness. ;-)

	Greetings, Andreas