Call for testing: OpenSSH-5.7

[Corinna Vinschen]

On Jan 14 15:08, Damien Miller wrote:
> Hi,
> 
> Thanks everyone for their test reports. Last night Tim Rice and I fixed
> some makefile and regress test problems that were causing some tests
> not to run completely.
> 
> If you have the opportunity, we'd appreciate if you could rerun your tests
> with the latest snapshot (20110114).

All tests still pass on Cygwin, except for sftp-glob.

However, I'm a bit tired having to change regress/Makefile all the time
to run the tests.  Therefore, would you mind to apply the below patch?

It disables the sftp globbing tests testing backslashes in filenames.
These can't work due to backslashes being directory separators on
Windows(*).


Thanks,
Corinna

(*) It occured to me that Cygwin could enable some sort of "strict POSIX"
    mode, which disallows to enter DOS paths, and which in turn would
    convert backslashes to simple characters allowed in filenames.
    There's already code in Cygwin which handles other characters not
    allowed in Windows filenames (<, >, ?, *, |) by transposing them
    into the UNICODE private use area U+f0XX.  However, this "strict
    POSIX" mode isn't implemented yet, and even *if* it gets implemented
    it would be the user's choice to use it, so I'd rather disable the
    affected tests in sftp-glob.sh.


Index: regress/sftp-glob.sh
===================================================================
RCS file: /cvs/openssh/regress/sftp-glob.sh,v
retrieving revision 1.5
diff -u -p -r1.5 sftp-glob.sh
--- regress/sftp-glob.sh	6 Oct 2009 23:43:57 -0000	1.5
+++ regress/sftp-glob.sh	14 Jan 2011 13:02:29 -0000
@@ -45,7 +45,14 @@ SPACE="${DIR}/g-q space"
 rm -rf ${BASE}
 mkdir -p ${DIR}
 touch "${DATA}" "${GLOB1}" "${GLOB2}" "${QUOTE}"
-touch "${QSLASH}" "${ESLASH}" "${SLASH}" "${SPACE}"
+case `uname -s` in
+CYGWIN*)
+	;;
+*)
+	touch "${QSLASH}" "${ESLASH}" "${SLASH}"
+	;;
+esac
+touch "${SPACE}"
 
 #       target                   message                expected     unexpected
 sftp_ls "${DIR}/fil*"            "file glob"            "${DATA}"    ""
@@ -55,12 +62,18 @@ sftp_ls "${DIR}/g-wild\*"        "escape
 sftp_ls "${DIR}/g-quote\\\""     "escaped quote"        "g-quote\""  ""
 sftp_ls "\"${DIR}/g-quote\\\"\"" "quoted quote"         "g-quote\""  ""
 sftp_ls "'${DIR}/g-quote\"'"     "single-quoted quote"  "g-quote\""  ""
-sftp_ls "${DIR}/g-sl\\\\ash"     "escaped slash"        "g-sl\\ash"  ""
-sftp_ls "'${DIR}/g-sl\\\\ash'"   "quoted slash"         "g-sl\\ash"  ""
-sftp_ls "${DIR}/g-slash\\\\"     "escaped slash at EOL" "g-slash\\"  ""
-sftp_ls "'${DIR}/g-slash\\\\'"   "quoted slash at EOL"  "g-slash\\"  ""
-sftp_ls "${DIR}/g-qs\\\\\\\""    "escaped slash+quote"  "g-qs\\\""   ""
-sftp_ls "'${DIR}/g-qs\\\\\"'"    "quoted slash+quote"   "g-qs\\\""   ""
+case `uname -s` in
+CYGWIN*)
+	;;
+*)
+	sftp_ls "${DIR}/g-sl\\\\ash"     "escaped slash"        "g-sl\\ash"  ""
+	sftp_ls "'${DIR}/g-sl\\\\ash'"   "quoted slash"         "g-sl\\ash"  ""
+	sftp_ls "${DIR}/g-slash\\\\"     "escaped slash at EOL" "g-slash\\"  ""
+	sftp_ls "'${DIR}/g-slash\\\\'"   "quoted slash at EOL"  "g-slash\\"  ""
+	sftp_ls "${DIR}/g-qs\\\\\\\""    "escaped slash+quote"  "g-qs\\\""   ""
+	sftp_ls "'${DIR}/g-qs\\\\\"'"    "quoted slash+quote"   "g-qs\\\""   ""
+	;;
+esac
 sftp_ls "${DIR}/g-q\\ space"     "escaped space"        "g-q space"  ""
 sftp_ls "'${DIR}/g-q space'"     "quoted space"         "g-q space"  ""
 


-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat