unconitionally use socketpair?
Darren Tucker
dtucker at zip.com.au
Fri Jun 3 14:04:57 EST 2011
On Fri, Jun 3, 2011 at 12:08 PM, Darren Tucker <dtucker at zip.com.au> wrote:
[...]
> We could just stick a null implementation of socketpair in the compat
> library that just returns failure and sets errno to ENOENT or
> something. That'd allow any such systems to still compile and mostly
> work, without adding to the work of pulling changes from OpenBSD.
I committed the removal. This code has been in sshd.c for ~5y without
an ifdef, so anything that doesn't have socketpair is long broken.
if (rexec_flag && socketpair(AF_UNIX,
SOCK_STREAM, 0, config_s) == -1) {
--
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69
Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.
More information about the openssh-unix-dev
mailing list