[PATCH/cygwin]: Explicitely undefine _WIN32

Corinna Vinschen vinschen at redhat.com
Mon Mar 19 20:28:43 EST 2012


On Mar 17 09:07, Glenn Maynard wrote:
> On Sat, Mar 17, 2012 at 5:10 AM, Corinna Vinschen <vinschen at redhat.com>wrote:
> 
> > +/* Make sure _WIN32 isn't defined later in the code, otherwise headers
> > from
> > +   other packages might get the wrong idea about the target system. */
> > +#ifdef _WIN32
> > +#undef _WIN32
> > +#endif
> >
> 
> #undef for an undefined macro should be a no-op, so the #ifdef should be
> unnecessary.

You're right.  BUt it looks cleaner, doesn't it?  Anyway, whoever has
checkin rights, please apply any one of the patches you like better.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat


More information about the openssh-unix-dev mailing list