Invalid user name: function okname() in scp.c

[Reza Hedayat]

Hi Ángel

I've just wanted to enquire about the status of the discussed problem 
concerning the prohibition of hash sign characters in usernames by using 
scp.
Is there a chance that you will remove the complete constraint from the 
function okname()?.

Best wishes
Reza


On 04/11/12 10:11, Reza Hedayat wrote:
> Hi Ángel
>
> Sorry for my late response, but your solution approach was in 
> clarification.
> Unfortunately, all user names on the IBM AS/400 systems of our 
> customer have a hash sign at the *first position*.
> Therefore, your solution will not solve this problem.
>
> As I've written in my last mail, SSH client and SFTP work perfectly 
> with # characters in user names.
> Therefore, SCP should also work identically.
> So, why can't we just adapt the logic in SCP and allow # characters 
> like in SSH and SFTP?
>
> Best wishes
> Reza
>
>
> On 03/17/12 01:21, Ángel González wrote:
>> On 14/03/12 12:07, Reza Hedayat wrote:
>>> Hi Ángel
>>>
>>> I just wanted to enquire if there is a chance that you will remove the
>>> hash sign (#) validation from the OpenSSH code base.
>>>
>>> Even the attempt to escape the # character results in rejection of the
>>> complete command by SCP.
>>> SSH client and SFTP work perfectly with # characters in user names, it
>>> is just SCP that rejects it.
>>> On the server side there are IBM AS/400 systems having usernames
>>> containing # characters, which are completely valid, legal and
>>> commonplace on that platform.
>>>
>>> Best wishes
>>> Reza
>> Hello Reza,
>> I gave it a go. See the attached patch.
>> I just allowed # in the middle of a word, which _should_ be safe to do,
>> as in it's only special for a shell as the first token character (per
>> POSIX rules).
>> It seems to work fine.
>>
>> Best regards
>>
>>
>>

-- 
AdNovum Informatik AG
Reza Hedayat, Software Engineer
Dipl. Informatik-Ing. FH

Roentgenstrasse 22, CH-8005 Zurich
mailto:reza.hedayat at adnovum.ch
phone: +41 44 272 6111, fax: +41 44 272 6312
http://www.adnovum.ch

AdNovum Locations: Bern, Budapest, Singapore, Zurich (HQ)