openssh-unix-dev Digest, Vol 123, Issue 13

[Loganaden Velvindron]

usage() lacks the a flag:

Index: sftp.c
===================================================================
RCS file: /cvs/openssh/sftp.c,v
retrieving revision 1.161
diff -u -p -r1.161 sftp.c
--- sftp.c	25 Jul 2013 01:56:52 -0000	1.161
+++ sftp.c	31 Jul 2013 21:49:57 -0000
@@ -2116,7 +2116,7 @@ usage(void)
 	extern char *__progname;

 	fprintf(stderr,
-	    "usage: %s [-1246Cpqrv] [-B buffer_size] [-b batchfile] [-c cipher]\n"
+	    "usage: %s [-1246aCpqrv] [-B buffer_size] [-b batchfile] [-c cipher]\n"
 	    "          [-D sftp_server_path] [-F ssh_config] "
 	    "[-i identity_file] [-l limit]\n"
 	    "          [-o ssh_option] [-P port] [-R num_requests] "


http://elandsys.com/~logan/sftp.c.diff



On Thu, Aug 1, 2013 at 1:34 AM, Loganaden Velvindron <loganaden at gmail.com>wrote:

> My test:
>
> reget'ing an existing file:
>
> sftp> reget 1000M
> Resuming /root/1000M to 1000M
> /root/1000M                                   100% 1000MB   0.0KB/s   00:00
>
> Interrupting a download and trying again:
> sftp> reget 1000M
> Resuming /root/1000M to 1000M
> /root/1000M                                     3%   40MB  10.0MB/s
> 01:36 ETA^Interrupt
> /root/1000M                                     4%   46MB   9.7MB/s
> 01:38 ETA
> Resuming /root/1000M to 1000M
> /root/1000M                                    10%  106MB   9.8MB/s
> 01:31 ETA^Interrupt
> sftp> reget 1000M
> Resuming /root/1000M to 1000M
> /root/1000M                                    13%  138MB   9.8MB/s
> 01:28 ETA^Interrupt
>
> sftp> reget 1000M
> Resuming /root/1000M to 1000M
> /root/1000M                                   100% 1000MB  11.5MB/s   01:27
>
>
>
>
> On Thu, Aug 1, 2013 at 1:30 AM, Loganaden Velvindron <loganaden at gmail.com>wrote:
>
>> Hi Iain,
>>
>> Can you please try this patch ?
>>
>> Index: progressmeter.c
>> ===================================================================
>> RCS file: /cvs/openssh/progressmeter.c,v
>> retrieving revision 1.40
>> diff -u -p -r1.40 progressmeter.c
>> --- progressmeter.c	2 Jun 2013 13:46:24 -0000	1.40
>> +++ progressmeter.c	31 Jul 2013 21:27:25 -0000
>> @@ -147,7 +147,7 @@ refresh_progress_meter(void)
>>  	if (elapsed != 0)
>>  		cur_speed = (transferred / elapsed);
>>  	else
>> -		cur_speed = transferred;
>> +		cur_speed = transferred - *counter;
>>
>>  #define AGE_FACTOR 0.9
>>  	if (bytes_per_second != 0) {
>>
>>
>> In case the diff gets garbled, it's available here:
>>
>> http://elandsys.com/~logan/progressmeter.diff
>>
>>
>>
>>
>> On Wed, Jul 31, 2013 at 10:31 AM, Loganaden Velvindron <
>> loganaden at gmail.com> wrote:
>>
>>>
>>>
>>>
>>> On Wed, Jul 31, 2013 at 9:04 AM, Loganaden Velvindron <
>>> loganaden at gmail.com> wrote:
>>>
>>>>
>>>>
>>>>> Message: 8
>>>>> Date: Tue, 30 Jul 2013 12:46:50 -0700
>>>>> From: Iain Morgan <imorgan at nas.nasa.gov>
>>>>> To: Damien Miller <djm at mindrot.org>
>>>>> Cc: "openssh-unix-dev at mindrot.org" <openssh-unix-dev at mindrot.org>
>>>>> Subject: Re: Call for testing: OpenSSH-6.3
>>>>> Message-ID: <20130730194649.GC18047 at linux124.nas.nasa.gov>
>>>>> Content-Type: text/plain; charset=us-ascii
>>>>>
>>>>> On Wed, Jul 24, 2013 at 22:35:25 -0500, Damien Miller wrote:
>>>>> > Hi,
>>>>> >
>>>>> > OpenSSH 6.3 is almost ready for release, so we would appreciate
>>>>> testing
>>>>> > on as many platforms and systems as possible. This release contains
>>>>> > some substantial new features and a number of bugfixes.
>>>>> >
>>>>> [snip]
>>>>> >
>>>>> >  * sftp(1): add support for resuming partial downloads using the
>>>>> "reget"
>>>>> >    command and on the sftp commandline or on the "get" commandline
>>>>> using
>>>>> >    the "-a" (append) option.
>>>>> >
>>>>>
>>>>> Some initial testing of the reget functionality shows that its
>>>>> interaction with the progress meter code is a bit buggy. In one test,
>>>>> it
>>>>> reported an inordinately high initial rate. In another test, it
>>>>> reported
>>>>> a negative rate.
>>>>>
>>>>> A simple test is to reget a file which was already transferred
>>>>> successfully:
>>>>>
>>>>> sftp> reget testfile.10gb
>>>>> Resuming /nobackupp1/imorgan/testfile.10gb to testfile.10gb
>>>>> /nobackupp1/imorgan/testfile.10gb               100%   10GB
>>>>> -2097151.-9KB/s   00:
>>>>> sftp>
>>>>>
>>>>> I think I hit a similar case:
>>>
>>> sftp> reget foo2
>>> Resuming /home/loganaden/foo2 to foo2
>>> /home/loganaden/foo2                          100% 2048KB  48.8KB/s
>>> 00:42
>>> sftp> reget foo2
>>> Resuming /home/loganaden/foo2 to foo2
>>> /home/loganaden/foo2                          100% 2048KB   2.0MB/s
>>> 00:00
>>>
>>> I'm currently looking into this.
>>>
>>>
>>>
>>>>  --
>>>>> Iain Morgan
>>>>>
>>>>>
>>>>> I didn't encounter such problems during my testing. I'll try again @
>>>> work with huge files
>>>> and see if I can reproduce this.
>>>>
>>>>
>>>>
>>>>> ------------------------------
>>>>>
>>>>> _______________________________________________
>>>>> openssh-unix-dev mailing list
>>>>> openssh-unix-dev at mindrot.org
>>>>> https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
>>>>>
>>>>>
>>>>> End of openssh-unix-dev Digest, Vol 123, Issue 13
>>>>> *************************************************
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> This message is strictly personal and the opinions expressed do not
>>>> represent those of my employers, either past or present.
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> This message is strictly personal and the opinions expressed do not
>>> represent those of my employers, either past or present.
>>>
>>>
>>>
>>>
>>>
>>
>>
>> --
>> This message is strictly personal and the opinions expressed do not
>> represent those of my employers, either past or present.
>>
>>
>>
>>
>>
>
>
> --
> This message is strictly personal and the opinions expressed do not
> represent those of my employers, either past or present.
>
>
>
>
>


-- 
This message is strictly personal and the opinions expressed do not
represent those of my employers, either past or present.