Call for testing: OpenSSH-6.3

[Damien Miller]

excellent - thanks again for testing. Darren, could you please commit?

On Mon, 5 Aug 2013, Kevin Brott wrote:

> 
> Applying patch to openssh-SNAP-20130806.tar.gz - and testing against oldest
> four hosts gives ...
> 
> Using http://www.mindrot.org/openssh_snap/openssh-SNAP-20130806p1.tar.gz
> 
> OS              Build_Target                CC                  OpenSSL     
> BUILD TEST
> ==============  =========================== ================    ============
> ===== =================
> RHEL 2.1        i686-pc-linux-gnu           gcc 2.96-129.7.2    0.9.6b-eng  
> OK    all tests passed
> RHL 8.0         i686-pc-linux-gnu           gcc 3.2.2-5         0.9.7a      
> OK    all tests passed
> RHEL 3.0        i686-pc-linux-gnu           gcc 3.2.3-20        0.9.7a      
> OK    all tests passed   
> Fedora Core r2  i686-pc-linux-gnu           gcc 3.3.3-7         0.9.7a      
> OK*1  all tests passed
> 
> # RHL     Red Hat Linux
> # RHEL    Red Hat Enterprise Linux
> 
> # *1 --without-zlib-version-check
> 
> So it looks like that patch works fine for the hosts with the previous build
> issue - without breaking the ones that already worked.
> 
> 
> 
> On Sat, Aug 3, 2013 at 6:20 PM, Damien Miller <djm at mindrot.org> wrote:
>       On Sat, 3 Aug 2013, Darren Tucker wrote:
> 
>       > > We could add a runtime fallback in misc.c:monotime() but
>       it'd be kinda
>       > > ugly.
>       >
>       > Like this?
> 
> ok djm if it fixes Kevin's problem. Kevin, could you please try this
> patch?
> 
> > Index: misc.c
> > ===================================================================
> > RCS file: /home/dtucker/openssh/cvs/openssh/misc.c,v
> > retrieving revision 1.118
> > diff -u -p -r1.118 misc.c
> > --- misc.c    18 Jul 2013 06:13:19 -0000      1.118
> > +++ misc.c    3 Aug 2013 08:41:31 -0000
> > @@ -859,14 +859,17 @@ monotime(void)
> >  {
> >  #if defined(HAVE_CLOCK_GETTIME) && defined(CLOCK_MONOTONIC)
> >       struct timespec ts;
> > +     static int gettime_failed = 0;
> >
> > -     if (clock_gettime(CLOCK_MONOTONIC, &ts) != 0)
> > -             fatal("clock_gettime: %s", strerror(errno));
> > +     if (!gettime_failed) {
> > +             if (clock_gettime(CLOCK_MONOTONIC, &ts) == 0)
> > +                     return (ts.tv_sec);
> > +             debug3("clock_gettime: %s", strerror(errno));
> > +             gettime_failed = 1;
> > +     }
> > +#endif
> >
> > -     return (ts.tv_sec);
> > -#else
> >       return time(NULL);
> > -#endif
> >  }
> >
> >  void
> >
> > --
> > Darren Tucker (dtucker at zip.com.au)
> > GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4
> FA69
> >     Good judgement comes with experience. Unfortunately, the
> experience
> > usually comes from bad judgement.
> > _______________________________________________
> > openssh-unix-dev mailing list
> > openssh-unix-dev at mindrot.org
> > https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
> >
> 
> 
> 
> 
> --
> # include <stddisclaimer.h>
> /* Kevin  Brott <Kevin.Brott at gmail.com> */
> 
> 
>