Call for testing: OpenSSH-6.2

[Darren Tucker]

On Tue, Mar 05, 2013 at 08:18:17PM +1100, Darren Tucker wrote:
> it *does* seem related to make, though, since it'll build fine with GNU
> make.

I think I found it.  Makefile.in has:

PATHS= -DSSHDIR=\"$(sysconfdir)\" \
        ...
        -D_PATH_PRIVSEP_CHROOT_DIR=\"$(PRIVSEP_PATH)\" \

CC=gcc

CPPFLAGS=-I. -I$(srcdir) @CPPFLAGS@ $(PATHS) @DEFS@

Note the trailing "\" on the last line of PATHS=.  It looks like HP-UX's
make ignores the blank line (which is probably a bug) and appends CC=gcc
to $(PATHS).  Eventually make runs:

cc ... -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\"  CC=gcc -DHAVE_CONFIG_H -c authfd.c

which chokes.  It's been there a lot longer than than I expected:

revision 1.322
date: 2011-05-05 13:48:37 +1000;  author: djm;  state: Exp;  lines: +10 -40;
 - (djm) [Makefile.in WARNING.RNG aclocal.m4 buildpkg.sh.in configure.ac]
   [entropy.c ssh-add.c ssh-agent.c ssh-keygen.c ssh-keyscan.c]
   [ssh-keysign.c ssh-pkcs11-helper.c ssh-rand-helper.8 ssh-rand-helper.c]
   [ssh.c ssh_prng_cmds.in sshd.c contrib/aix/buildbff.sh]
   [regress/README.regress] Remove ssh-rand-helper and all its
   tentacles. PRNGd seeding has been rolled into entropy.c directly.
   Thanks to tim@ for testing on affected platforms.

This patch ought to fix it:

Index: Makefile.in
===================================================================
RCS file: /home/dtucker/openssh/cvs/openssh/Makefile.in,v
retrieving revision 1.333
diff -u -r1.333 Makefile.in
--- Makefile.in	21 Feb 2013 23:40:00 -0000	1.333
+++ Makefile.in	5 Mar 2013 10:33:13 -0000
@@ -37,7 +37,7 @@
 	-D_PATH_SSH_KEY_SIGN=\"$(SSH_KEYSIGN)\" \
 	-D_PATH_SSH_PKCS11_HELPER=\"$(SSH_PKCS11_HELPER)\" \
 	-D_PATH_SSH_PIDDIR=\"$(piddir)\" \
-	-D_PATH_PRIVSEP_CHROOT_DIR=\"$(PRIVSEP_PATH)\" \
+	-D_PATH_PRIVSEP_CHROOT_DIR=\"$(PRIVSEP_PATH)\"
 
 CC=@CC@
 LD=@LD@

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.