additional compiler hardening flags

[Darren Tucker]

On Sat, Jan 18, 2014 at 5:35 AM, Alan Barrett <apb at cequrux.com> wrote:
> On Fri, 17 Jan 2014, Corinna Vinschen wrote:
>>
>> Here's the first one:
>>
>>   ../../src/openbsd-compat/fmt_scaled.c:84:2: error: array subscript has
>> type ‘char’ [-Werror=char-subscripts]
>>     while (isascii(*p) && isspace(*p))
>>     ^
> If the openssh developers are interested in fixing this bug, I refer them to
> the spatch which I submitted several years ago, in
> <https://lists.mindrot.org/pipermail/openssh-unix-dev/2010-August/028895.html>

Sorry, I don't recall looking at that, or if I did I intended to go
back to it after that particular release and didn't.

Anyway, most of those have been fixed upstream recently and these
changes have been pulled into Portable.  The ones that haven't are in
the library functions we pull from OpenBSD but are not part of the
main OpenSSH source.

These have also have been fixed upstream, but there are other
non-trivial changes in those files too.  The choices are:
 a) pull in all the changes for the release and risk breaking something
 b) pull in just the ctype fixes for the release

I am not inclined to do a) until after the release, but doing b)
before the release makes that messier.  I'm leaning toward leaving
those 3 files until immediately after the release.

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.