Call for testing: OpenSSH-6.5

[Darren Tucker]

On Sat, Jan 18, 2014 at 09:30:24AM +1100, Damien Miller wrote:
> On Sat, 18 Jan 2014, Darren Tucker wrote:
> 
> > build failure on netbsd4 with gssapi enabled while linking sshd:
> > 
> > gss-serv-krb5.o: In function `ssh_gssapi_krb5_storecreds?:
> > gss-serv-krb5.c:135: undefined reference to `krb5_cc_new_unique?
> 
> hmm, that line has been there for a while. No obvious changes to
> krb5 detection in configure.ac either...

Turns out we already detect this in configure and handle it in
auth-krb5.c.  ok?

Index: gss-serv-krb5.c
===================================================================
RCS file: /home/dtucker/openssh/cvs/openssh/gss-serv-krb5.c,v
retrieving revision 1.18
diff -u -p -r1.18 gss-serv-krb5.c
--- gss-serv-krb5.c	20 Jul 2013 03:35:45 -0000	1.18
+++ gss-serv-krb5.c	20 Jan 2014 01:58:33 -0000
@@ -132,10 +132,16 @@ ssh_gssapi_krb5_storecreds(ssh_gssapi_cl
 		return;
 
 #ifdef HEIMDAL
+# ifdef HAVE_KRB5_CC_NEW_UNIQUE
 	if ((problem = krb5_cc_new_unique(krb_context, krb5_fcc_ops.prefix,
 	    NULL, &ccache)) != 0) {
 		errmsg = krb5_get_error_message(krb_context, problem);
 		logit("krb5_cc_new_unique(): %.100s", errmsg);
+# else
+	if ((problem = krb5_cc_gen_new(krb_context, &krb5_fcc_ops, &ccache))) {
+	    logit("krb5_cc_gen_new(): %.100s",
+		krb5_get_err_text(krb_context, problem));
+# endif
 		krb5_free_error_message(krb_context, errmsg);
 		return;
 	}

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.