Call for testing: OpenSSH-6.5

[Hisashi T Fujinaka]

On Sat, 25 Jan 2014, Darren Tucker wrote:

> Maybe there's something wrapping write() on your system too?  Try adding
> this to the start of atomicio.c:atomicio6():
>
> printf(stderr, "read %x write %x argument %x\n", read, vwrite, f);
>
> then compile it and run a small scp:
>
> $ ./scp testfile localhost:/tmp/
> read b73eced0 write b73ecf50 argument b73eced0
>
> The patch below makes the first argument to atomicio an int rather than
> a function pointer.
>
> On the plus side: it also allows the removal of some hacks around
> vwrite/writev.  On the minus side: it's a large change albeit mostly
> mechanical.

I tried building after applying the patch, but I think I started in the wrong
place? I think I started with a fresh git clone.

Also, the scp told me it couldn't find /usr/local/bin/ssh. I'm guessing
there are environment variables I need.

gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wno-pointer-sign -Wno-unused-result -fno-strict-aliasing -D_FORTIFY_SOURCE=2 -ftrapv -fno-builtin-memset -fstack-protector-all -I. -I.  -DSSHDIR=\"/usr/local/etc\"  -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\"  -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/libexec/ssh-askpass\"  -D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\"  -D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\"  -D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\"  -D_PATH_SSH_PIDDIR=\"/var/run\"  -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c atomicio.c
atomicio.c: In function 'atomicio6':
atomicio.c:59:57: error: 'vwrite' undeclared (first use in this function)
atomicio.c:59:57: note: each undeclared identifier is reported only once for each function it appears in
atomicio.c:59:65: error: 'f' undeclared (first use in this function)
atomicio.c:59:2: warning: passing argument 1 of 'printf' from incompatible pointer type
/usr/include/stdio.h:249:6: note: expected 'const char * __restrict__' but argument is of type 'struct FILE *'
*** Error code 1



-- 
Hisashi T Fujinaka - htodd at twofifty.com
BSEE(6/86) + BSChem(3/95) + BAEnglish(8/95) + MSCS(8/03) + $2.50 = latte