Call for testing: OpenSSH-6.5

[Petr Lautrbach]

Hi,

regress/agent.sh reports wrong exit codes when some of tests fail:

run test agent.sh ...
agent fwd proto 1 failed (exit code 0)
agent fwd proto 2 failed (exit code 0)
failed simple agent test

It's probably due to using $? value in error message after
"if [ $? -ne 0 ]; then"
which sets $? to 0.

With the attached patch, the output would look like:
run test agent.sh ...
agent fwd proto 1 failed (exit code 255)
agent fwd proto 2 failed (exit code 255)
failed simple agent test


I noticed it when I'd run "make tests" by an user, who runs ssh-agent with a static socket from .bashrc:
eval `ssh-agent -a /tmp/plautrba/.ssh-agent.sock`

In this case, the agent.sh always fails, but I consider this more as a configuration issue than
a real bug in test suite.

However, with the standard .bashrc I can confirm that "make tests" passes on RHEL-7 Beta.

Thanks,

Petr
-- 
Petr Lautrbach
Security Technologies
Red Hat

Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: agent.sh.patch
Type: text/x-patch
Size: 1687 bytes
Desc: not available
URL: <http://lists.mindrot.org/pipermail/openssh-unix-dev/attachments/20140128/947b3a2e/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.mindrot.org/pipermail/openssh-unix-dev/attachments/20140128/947b3a2e/attachment-0003.bin>