Read-only on /dev/tty causes ssh-add to show passwords when typed and ssh'ing to new hosts to fail

[Gert Doering]

Hi,

On Sun, Jul 20, 2014 at 08:01:42PM +1000, Damien Miller wrote:
> There isn't much ssh can do with bad permissions on /dev/tty.

Well - you could issue an error message and die.

Termios operation on stdin(-connected-to-a-tty) do not need /dev/tty, so
there must be some explicit open() somewhere - and if that fails, do not
go on.  Without having checked the code, it might be some sort of corner
case ("if this fails we do not have a controlling tty, so use stdin instead
and do not try to turn off echo instead!" - not differenciating between
the error for "no controlling tty" and "broken permissions").

gert
-- 
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             gert at greenie.muc.de
fax: +49-89-35655025                        gert at net.informatik.tu-muenchen.de