[PATCH] Expand tilde for UNIX domain socket forwards.

Ángel González keisial at gmail.com
Sat Aug 22 08:49:43 AEST 2015


The name is not that bad, and the code looks ok.



On 19/08/15 04:31, Todd C. Miller wrote:
> diff -u -p -u -r1.54 misc.h
> --- misc.h	15 Jul 2014 15:54:14 -0000	1.54
> +++ misc.h	19 Aug 2015 02:27:37 -0000
> @@ -49,7 +49,8 @@
> char *cleanhostname(char *);
> char *colon(char *);
> long convtime(const char *);
> char *tilde_expand_filename(const char *, uid_t);
> +int tilde_expand_filename2(const char *, char **, uid_t);
> char *percent_expand(const char *, ...) __attribute__((__sentinel__));
> char *tohex(const void *, size_t);
Note that here you are breaking the alignment of function names. (yep, 
completely minor)



More information about the openssh-unix-dev mailing list