Call for testing: OpenSSH 6.8

[Darren Tucker]

On Mon, Feb 23, 2015 at 04:17:37PM -0800, Kevin Brott wrote:
> Hrm - must have been a timing issue or my user error.  In any case, just
> pulled the latest commits ...
> 
> *AIX 6.1/7.1 now fails here:*
> *...*
>         xlc_r -O2 -qarch=ppc -qalloca -I/usr/include
> -I/opt/freeware/include  -I. -I. -O2 -qarch=ppc -qalloca -I/usr/include
> -I/opt/freeware/include -DSSHDIR=\"/usr/local/etc\"
>  -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\"
>  -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/libexec/ssh-askpass\"
>  -D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\"
>  -D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\"
>  -D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\"
>  -D_PATH_SSH_PIDDIR=\"/var/run\"  -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\"
> -DHAVE_CONFIG_H -c packet.c -o packet.o
> "/usr/include/openssl/objects.h", line 1009.31: 1506-275 (S) Unexpected
> text free_func encountered.
> make: 1254-004 The error code from the last command is 1.

I also ran into this on old GCCs.  It seems to be related to include
orders although I don't understand why.  On a hunch I tried this which
seems to fix it for me, but again I don't understand why...

Does it also help for you?

diff --git a/packet.c b/packet.c
index b1219c8..b15f02f 100644
--- a/packet.c
+++ b/packet.c
@@ -51,6 +51,8 @@
 #include <netinet/ip.h>
 #include <arpa/inet.h>
 
+#include <openssl/objects.h>
+
 #include <errno.h>
 #include <stdarg.h>
 #include <stdio.h>

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.