hostkey-rotate, grep and two line search pattern

Damien Miller djm at mindrot.org
Wed Mar 4 04:54:40 AEDT 2015


On Tue, 3 Mar 2015, Roumen Petrov wrote:

> Hello,
> 
> Regression test hostkey-rotate .
> 
> After 'learn new primary' known_hosts contain both rsa keys - old and new one.
> Function check_key_present use awk to get search pattern and script return two
> lines.
> In such case Solaris grep command return error 41.
> Simple test command:
> $ grep '1
> > 2' /tmp/a
> grep: RE error 41: No remembered search string.
> 
> It is reported in [1] with patch to change grep to fgrep.
> As fgrep use "pattern as a list of fixed strings, separated by newlines" fgrep
> could be used to resolve issue.
> 
> 
> I would like to propose another correction - change logic of check_key_present
> to search known_hosts for public key.
> Attached file implement new search. It use 'fgrep ... > /dev/null'. Also 'grep
> -q ..' works well.

applied - thanks.

-d


More information about the openssh-unix-dev mailing list