Name based SSH proxy

Peter Stuge peter at stuge.se
Tue May 26 09:50:05 AEST 2015


Kasper Dupont wrote:
> +send_client_banner(int connection_out, int minor1, const char *host)
>  {
>  	/* Send our own protocol version identification. */
>  	if (compat20) {
> -		xasprintf(&client_version_string, "SSH-%d.%d-%.100s\r\n",
> -		    PROTOCOL_MAJOR_2, PROTOCOL_MINOR_2, SSH_VERSION);
> +		xasprintf(&client_version_string,
> +		    "SSH-%d.%d-%.100s {\"SNI\": \"%.133s\"}\r\n",
> +		    PROTOCOL_MAJOR_2, PROTOCOL_MINOR_2, SSH_VERSION, host);

You propose introducing JSON injection. Really?

Aside from all the other valid criticism, JSON is a bad fit.


//Peter


More information about the openssh-unix-dev mailing list