OpenSSH 7.3p1 can't be build on Solaris 10

[Darren Tucker]

On Tue, Aug 2, 2016 at 12:52 AM, Darren Tucker <dtucker at zip.com.au> wrote:
[...]
>> Seems can't. But why? 7.2 does.
>
> Dunno, I can't think of any obvious changes to compiler flags.  Maybe
> try it without setting CFLAGS?

OK, I think I see why it started in 7.3: it was when the wide
character support was added.  In configure.ac:

dnl Wide character support.  Linux man page says it needs _XOPEN_SOURCE.
saved_CFLAGS="$CFLAGS"
CFLAGS="$CFLAGS -D_XOPEN_SOURCE"
AC_CHECK_FUNCS([mblen mbtowc nl_langinfo wcwidth])
CFLAGS="$saved_CFLAGS"

AC_LINK_IFELSE(
        [AC_LANG_PROGRAM(and
           [[ #include <ctype.h> ]],
           [[ return (isblank('a')); ]])],
        [AC_DEFINE([HAVE_ISBLANK], [1], [Define if you have isblank(3C).])
])

before that the mblen test didn't have XOPEN_SOURCE.

The failing condition is "if defined(_STDC_C99) &&
(defined(__XOPEN_OR_POSIX) && !defined(_XPG6))".  The above explains
where the XOPEN came from.  As to why you're seeing it, my guess is
your version of gcc defaults to -std=c99 and mine doesn't.  You can
try adding "-std=c89" to your CFLAGS and see if it builds.

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860  37F4 9357 ECEF 11EA A6FA (new)
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.