Call for testing: OpenSSH 7.2

[Tom G. Christensen]

On 12/02/16 04:56, Damien Miller wrote:
> Portable OpenSSH is available via Git at
> https://anongit.mindrot.org/openssh.git/ or via a mirror on Github at
> https://github.com/openssh/openssh-portable
>

Building V_7_1_P1-189-g5ac712d on Solaris 2.6 fails:
make[1]: Entering directory 
`/export/home/tgc/buildpkg/openssh/src/openssh-git/openbsd-compat'
gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare 
-Wformat-security -Wno-pointer-sign -fno-strict-aliasing 
-D_FORTIFY_SOURCE=2 -ftrapv -fno-builtin-memset -fstack-protector-all 
-I. -I.. -I. -I./.. -I/usr/tgcware/include -DHAVE_CONFIG_H -c bsd-asprintf.c
bsd-asprintf.c:50:13: error: macro "va_start" requires 2 arguments, but 
only 1 given
bsd-asprintf.c: In function 'vasprintf':
bsd-asprintf.c:50: error: 'va_start' undeclared (first use in this function)
bsd-asprintf.c:50: error: (Each undeclared identifier is reported only once
bsd-asprintf.c:50: error: for each function it appears in.)
make[1]: *** [bsd-asprintf.o] Error 1
make[1]: Leaving directory 
`/export/home/tgc/buildpkg/openssh/src/openssh-git/openbsd-compat'
make: *** [openbsd-compat/libopenbsd-compat.a] Error 2

I removed the call to va_start just to see if there would be any other 
errors lurking and there is:
gcc -o ssh ssh.o readconf.o clientloop.o sshtty.o sshconnect.o 
sshconnect1.o sshconnect2.o mux.o -L. -Lopenbsd-compat/ 
-R/usr/tgcware/lib -L/usr/tgcware/lib -Wl,-z,now -fstack-protector-all 
-lssh -lopenbsd-compat  -lcrypto -lposix4 -ldl -lresolv -lz -lsocket
ld: warning: symbol `umac_ctx' has differing sizes:
         (file ./libssh.a(umac.o) value=0x5ec; file 
./libssh.a(umac128.o) value=0x684);
         ./libssh.a(umac128.o) definition taken
Undefined                       first referenced
  symbol                             in file
gethostbyname 
openbsd-compat//libopenbsd-compat.a(fake-rfc2553.o)  (symbol belongs to 
implicit dependency /usr/lib/libnsl.so.1)
gethostbyaddr 
openbsd-compat//libopenbsd-compat.a(fake-rfc2553.o)  (symbol belongs to 
implicit dependency /usr/lib/libnsl.so.1)
ld: fatal: Symbol referencing errors. No output written to ssh
collect2: ld returned 1 exit status
make: *** [ssh] Error 1

It looks like the check for yp_match previously ensured that -lnsl was 
added.

-tgc