Call for testing: OpenSSH 7.2

Darren Tucker dtucker at zip.com.au
Wed Feb 17 09:22:59 AEDT 2016


On Tue, Feb 16, 2016 at 10:42:37PM +0100, Tom G. Christensen wrote:
> bsd-asprintf.c:50:13: error: macro "va_start" requires 2 arguments, but only
> 1 given

I think it's a problem with this commit:
https://anongit.mindrot.org/openssh.git/commit/openbsd-compat/bsd-asprintf.c?id=0f754e29dd3760fc0b172c1220f18b753fb0957e

Author: Damien Miller <djm at mindrot.org>
Date:   Fri Oct 16 10:53:14 2015 +1100

    need va_copy before va_start


diff --git a/openbsd-compat/bsd-asprintf.c b/openbsd-compat/bsd-asprintf.c
index db57acc..d393dfc 100644
--- a/openbsd-compat/bsd-asprintf.c
+++ b/openbsd-compat/bsd-asprintf.c
@@ -47,7 +47,7 @@ vasprintf(char **str, const char *fmt, va_list ap)
 	char *string, *newstr;
 	size_t len;
 
-	va_start(ap);
+	va_start(ap, fmt);
 	VA_COPY(ap2, ap);
 	if ((string = malloc(INIT_SZ)) == NULL)
 		goto fail;

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.


More information about the openssh-unix-dev mailing list