port-solaris.c:218: bad compare ?

Tanmay Tiwari tnmy44 at gmail.com
Tue Oct 25 19:57:24 AEDT 2016


Hi David,

Yes, IMO it should be changed to `!= 0`.

> A pointer can not be negative so it is either pointless or an error to
check if it is not.
That's not quite true, C standard doesn't force a valid pointer to be
positive only. It is implementation dependent. All the more reason that the
current code is fragile.


More information about the openssh-unix-dev mailing list