[PATCH] Enable specific ioctl calls for ICA crypto card (s390)

[Damien Miller]

On Tue, 28 Feb 2017, Eduardo Barretto wrote:

> On 13-02-2017 13:23, Eduardo Barretto wrote:
> > This patch enables specific ioctl calls for ICA crypto card on s390
> > platform. Without this patch, users using the IBMCA engine are not able
> > to perform ssh login as the filter blocks the communication with the
> > crypto card.
> > 
> > Signed-off-by: Harald Freudenberger <freude at linux.vnet.ibm.com>
> > Signed-off-by: Eduardo Barretto <ebarretto at linux.vnet.ibm.com>
> > ---
> >  sandbox-seccomp-filter.c | 24 +++++++++++++++++++++---
> >  1 file changed, 21 insertions(+), 3 deletions(-)
> > 
> > diff --git a/sandbox-seccomp-filter.c b/sandbox-seccomp-filter.c
> > index 2e1ed2c..264e146 100644
> > --- a/sandbox-seccomp-filter.c
> > +++ b/sandbox-seccomp-filter.c

[snip]

> Hi there,
> 
> Do you have any feedback on this patch?

It's hard to evaluate it without reference to some public documentation
for the crypto card and the syscalls needed to use it. Is it a standard
part of s390 machines or an option?

Does it provide substantial benefit for the crypto used in the pre-auth
stage of the protocol? (private key operations and DH/ECDH key agreement)

-d