OpenSSH 7.7 t1 script breakage

Randall S. Becker rsbecker at nexbridge.com
Fri Apr 13 04:45:18 AEST 2018


After getting OpenSSH 7.7 to build :), the initial test fails as follows:

test_kex:
............................................................................
............................................................................
............................................................................
............................................................................
................................................ 352 tests ok
test_hostkeys: .................. 18 tests ok
test_match: ...... 6 tests ok
/home/git/openssh-portable/ssh-keygen -if
/home/git/openssh-portable/regress/rsa_ssh2.prv | diff -
/home/git/openssh-portable/regress/rsa_openssh.prv
tr '\n' '\r' </home/git/openssh-portable/regress/rsa_ssh2.prv >
/home/git/openssh-portable/regress/rsa_ssh2_cr.prv
/home/git/openssh-portable/ssh-keygen -if
/home/git/openssh-portable/regress/rsa_ssh2_cr.prv | diff -
/home/git/openssh-portable/regress/rsa_openssh.prv
awk '{print $0 "\r"}' /home/git/openssh-portable/regress/rsa_ssh2.prv >
/home/git/openssh-portable/regress/rsa_ssh2_crnl.prv
/home/git/openssh-portable/ssh-keygen -if
/home/git/openssh-portable/regress/rsa_ssh2_crnl.prv | diff -
/home/git/openssh-portable/regress/rsa_openssh.prv
cat /home/git/openssh-portable/regress/rsa_openssh.prv > /regress/t2.out
/bin/sh: /regress/t2.out: cannot create

This comes down to the OBJ variable being set to
REGRESSTMP = "$(PWD)/regress" 

Which may work on some platforms but is not portable.
REGRESSTMP = `pwd` resolves properly

My proposed fix is this, which allows the tests to run in a generic
LINUX/POSIX environment and is agnostic to make.

+++ b/Makefile.in
@@ -577,7 +577,7 @@ regress-binaries: regress/modpipe$(EXEEXT) \
        regress/unittests/utf8/test_utf8$(EXEEXT) \
        regress/misc/kexfuzz/kexfuzz$(EXEEXT)

-REGRESSTMP = "$(PWD)/regress"
+REGRESSTMP = `pwd`

 tests interop-tests t-exec unit: regress-prep regress-binaries $(TARGETS)

Cheers,
Randall



More information about the openssh-unix-dev mailing list