vanilla build of 7.7p1 release on linux/4.17 fails with gcc8 @ "/usr/bin/ld: unrecognized option '-Wl,-z,retpolineplt'"

[Jakub Jelen]

On Fri, 2018-06-08 at 11:52 +1000, Darren Tucker wrote:
> On 8 June 2018 at 11:21, PGNet Dev <pgnet.dev at gmail.com> wrote:
> > fyi
> > 
> > add'l -- and looks unrelated -- issue
> >         /usr/include/pthread.h:251:12: note: previous declaration
> > of ‘pthread_join’ was here
> >          extern int pthread_join (pthread_t __th, void
> > **__thread_return);
> 
> What included pthread.h?  That's explicitly not supported by sshd:
> 
> $ grep THREAD auth-pam.c
> #ifdef USE_POSIX_THREADS
> # error "USE_POSIX_THREADS replaced by
> UNSUPPORTED_POSIX_THREADS_HACK"
>  * Formerly known as USE_POSIX_THREADS, using this is completely
> unsupported
> #ifdef UNSUPPORTED_POSIX_THREADS_HACK

The pthread.h was first included in the new OpenSSL 1.1.0, which uses
pthread.h and which conflicts with your pthread definitions.
This can be resolved by the first part of the OpenSSL 1.1.0 patch,
which we carry ever since:

https://src.fedoraproject.org/rpms/openssh/blob/master/f/openssh-7.3p1-
openssl-1.1.0.patch

Regards,
-- 
Jakub Jelen
Software Engineer
Security Technologies
Red Hat, Inc.