Call for testing: OpenSSH 8.0 [AIX Fail]
Kevin Brott
kevin.brott at gmail.com
Wed Apr 3 03:07:51 AEDT 2019
Using openssh-SNAP-20190403.tar.gz ... testing on current patchlevels of
AIX 7.1 and 7.2.
Mixed results - native builds using AIX's licensed xlC compiler compile and
pass all tests.
Builds using gcc/make from the Linux Toolbox get further - but die at
loginrec.o now:
AIX 7.2
=====
OpSys : AIX 7200-03-02-1846
Compiler: xlC (xlC.rte:13.1.3.1)
Make : aix make (bos.adt.base:7.2.3.15)
OpenSSL : OpenSSL 1.0.2p 14 Aug 2018 (openssl.base:1.0.2.1601)
*Results : all tests passed*
====
OpSys : AIX 7200-03-02-1846
Compiler: gcc (GCC) 8.1.0
Make : GNU Make 4.2.1
OpenSSL : OpenSSL 1.0.2p 14 Aug 2018
*Results : FAIL*
./configure && gmake tests
...
gcc -O2 -mcpu=powerpc -D_LINUX_SOURCE_COMPAT -pipe -Wall -Wpointer-arith
-Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess
-Wno-pointer-sign -Wno-unused-result -fno-strict-aliasing
-D_FORTIFY_SOURCE=2 -ftrapv -fno-builtin-memset -I. -I.
-I/opt/freeware/include -I/opt/phs/include -DSSHDIR=\"/usr/local/etc\"
-D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\"
-D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/libexec/ssh-askpass\"
-D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\"
-D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\"
-D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\"
-D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\"
-DHAVE_CONFIG_H -c loginrec.c -o loginrec.o
loginrec.c: In function 'login_write':
loginrec.c:469:31: warning: passing argument 1 of 'sys_auth_record_login'
from incompatible pointer type [-Wincompatible-pointer-types]
!sys_auth_record_login(li->username,li->hostname,li->line,
~~^~~~~~~~~~
In file included from openbsd-compat/openbsd-compat.h:334,
from includes.h:174,
from loginrec.c:148:
openbsd-compat/port-aix.h:93:27: note: expected 'struct ssh *' but argument
is of type 'char *'
int sys_auth_record_login(struct ssh *, const char *, const char *,
^~~~~~~~~~~~
loginrec.c:470:6: warning: passing argument 4 of 'sys_auth_record_login'
from incompatible pointer type [-Wincompatible-pointer-types]
loginmsg))
^~~~~~~~
In file included from openbsd-compat/openbsd-compat.h:334,
from includes.h:174,
from loginrec.c:148:
openbsd-compat/port-aix.h:94:5: note: expected 'const char *' but argument
is of type 'struct sshbuf *'
const char *, struct sshbuf *);
^~~~~~~~~~~~
loginrec.c:469:7: error: too few arguments to function
'sys_auth_record_login'
!sys_auth_record_login(li->username,li->hostname,li->line,
^~~~~~~~~~~~~~~~~~~~~
In file included from openbsd-compat/openbsd-compat.h:334,
from includes.h:174,
from loginrec.c:148:
openbsd-compat/port-aix.h:93:5: note: declared here
int sys_auth_record_login(struct ssh *, const char *, const char *,
^~~~~~~~~~~~~~~~~~~~~
gmake: *** [Makefile:161: loginrec.o] Error 1
=====
AIX 7.1
=====
OpSys : AIX 7100-05-03-1846
Compiler: xlC (xlC.rte:13.1.3.1)
Make : make (bos.adt.base:7.1.5.31)
OpenSSL : OpenSSL 1.0.2p 14 Aug 2018 (openssl.base:1.0.2.1601)
*Results : all tests passed*
=====
OpSys : AIX 7100-05-03-1846
Compiler: gcc (GCC) 6.3.0
Make : GNU Make 4.2.1
OpenSSL : OpenSSL 1.0.2p 14 Aug 2018
*Results : FAIL*
./configure && gmake tests
...
gcc -O2 -mcpu=powerpc -D_LINUX_SOURCE_COMPAT -pipe -Wall -Wpointer-arith
-Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess
-Wno-pointer-sign -Wno-unused-result -fno-strict-aliasing
-D_FORTIFY_SOURCE=2 -ftrapv -fno-builtin-memset -I. -I.
-I/opt/freeware/include -I/opt/phs/include -DSSHDIR=\"/usr/local/etc\"
-D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\"
-D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/libexec/ssh-askpass\"
-D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\"
-D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\"
-D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\"
-D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\"
-DHAVE_CONFIG_H -c loginrec.c -o loginrec.o
loginrec.c: In function 'login_write':
loginrec.c:469:29: warning: passing argument 1 of 'sys_auth_record_login'
from incompatible pointer type [-Wincompatible-pointer-types]
!sys_auth_record_login(li->username,li->hostname,li->line,
^~
In file included from openbsd-compat/openbsd-compat.h:334:0,
from includes.h:174,
from loginrec.c:148:
openbsd-compat/port-aix.h:93:5: note: expected 'struct ssh *' but argument
is of type 'char *'
int sys_auth_record_login(struct ssh *, const char *, const char *,
^~~~~~~~~~~~~~~~~~~~~
loginrec.c:470:6: warning: passing argument 4 of 'sys_auth_record_login'
from incompatible pointer type [-Wincompatible-pointer-types]
loginmsg))
^~~~~~~~
In file included from openbsd-compat/openbsd-compat.h:334:0,
from includes.h:174,
from loginrec.c:148:
openbsd-compat/port-aix.h:93:5: note: expected 'const char *' but argument
is of type 'struct sshbuf *'
int sys_auth_record_login(struct ssh *, const char *, const char *,
^~~~~~~~~~~~~~~~~~~~~
loginrec.c:469:7: error: too few arguments to function
'sys_auth_record_login'
!sys_auth_record_login(li->username,li->hostname,li->line,
^~~~~~~~~~~~~~~~~~~~~
In file included from openbsd-compat/openbsd-compat.h:334:0,
from includes.h:174,
from loginrec.c:148:
openbsd-compat/port-aix.h:93:5: note: declared here
int sys_auth_record_login(struct ssh *, const char *, const char *,
^~~~~~~~~~~~~~~~~~~~~
gmake: *** [Makefile:161: loginrec.o] Error 1
=====
On Tue, Apr 2, 2019 at 12:25 AM Darren Tucker <dtucker at dtucker.net> wrote:
> On Mon, 1 Apr 2019 at 23:23, Kevin Brott <kevin.brott at gmail.com> wrote:
> [...]
> > port-aix.c:316:1: error: conflicting types for 'record_failed_login'
> > record_failed_login(const char *user, const char *hostname, const char
> *ttyname)
>
> I think I just fixed that by changing the function to match the new
> prototype. Unfortunately I can't currently test it myself. Please
> report any further problems.
>
> Thanks!
>
>
> http://anongit.mindrot.org/openssh.git/commit/?id=138c0d52cdc90f9895333b82fc57d81cce7a3d90
>
> --
> Darren Tucker (dtucker at dtucker.net)
> GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new)
> Good judgement comes with experience. Unfortunately, the experience
> usually comes from bad judgement.
>
--
# include <stddisclaimer.h>
/* Kevin Brott <Kevin.Brott at gmail.com> */
More information about the openssh-unix-dev
mailing list