Call for testing: OpenSSH 8.0

[Jakub Jelen]

On Fri, 2019-03-29 at 12:29 +0100, Jakub Jelen wrote:
> On Wed, 2019-03-27 at 22:00 +1100, Damien Miller wrote:
> > Hi,
> > 
> > OpenSSH 8.0p1 is almost ready for release, so we would appreciate
> > testing
> > on as many platforms and systems as possible.
> > 
> > Snapshot releases for portable OpenSSH are available from
> > http://www.mindrot.org/openssh_snap/
> > 
> > The OpenBSD version is available in CVS HEAD:
> > http://www.openbsd.org/anoncvs.html
> > 
> > Portable OpenSSH is also available via git using the
> > instructions at http://www.openssh.com/portable.html#cvs
> > At https://anongit.mindrot.org/openssh.git/ or via a mirror at
> > Github:
> > https://github.com/openssh/openssh-portable
> > 
> > Running the regression tests supplied with Portable OpenSSH does
> > not
> > require installation and is a simply:
> > 
> > $ ./configure && make tests
> 
> For now, I have only one comment, but I plan to run more tests in our
> environment.

Trying to build the master, there is still one use of removed packet
api. The attached patch moves it to the new API.

Jakub


commit 9572372df606b74de1cb90b2e64e88b1c3237998
Author: Jakub Jelen <jjelen at redhat.com>
Date:   Wed Apr 3 16:51:12 2019 +0200

    session: Do not use removed API
    
    Signed-off-by: Jakub Jelen <jjelen at redhat.com>

diff --git a/session.c b/session.c
index c7d115a2..f2c3abde 100644
--- a/session.c
+++ b/session.c
@@ -2621,7 +2621,7 @@ session_setup_x11fwd(struct ssh *ssh, Session *s)
 		he = gethostbyname(hostname);
 		if (he == NULL) {
 			error("Can't get IP address for X11 DISPLAY.");
-			packet_send_debug("Can't get IP address for X11
DISPLAY.");
+			ssh_packet_send_debug(ssh, "Can't get IP
address for X11 DISPLAY.");
 			return 0;
 		}
 		memcpy(&my_addr, he->h_addr_list[0], sizeof(struct
in_addr));