[PATCH 2/2] Cygwin: implement case-insensitive Unicode user and group name matching

Damien Miller djm at mindrot.org
Fri Feb 22 16:50:09 AEDT 2019


On Fri, 22 Feb 2019, Darren Tucker wrote:

> On Fri, Feb 22, 2019 at 03:32:43PM +1100, Darren Tucker wrote:
> > On Wed, 20 Feb 2019 at 23:54, Corinna Vinschen <vinschen at redhat.com> wrote:
> > > The previous revert enabled case-insensitive user names again.  This
> > > patch implements the case-insensitive user and group name matching.
> > > To allow Unicode chars, implement the matcher using wchar_t chars in
> > > Cygwin-specific code.  Keep the generic code changes as small as possible.
> > > Cygwin: implement case-insensitive Unicode user and group name matching
> > 
> > Applied, thanks.
> > 
> > I think it might be possible to make this less intrusive by adding a
> > match_user_pattern_list() function that just calls match_pattern_list
> > on Unix-alikes and the Cygwin specific function there.  I'll take a
> > look.
> 
> How's this?  If we push the match_usergroup_pattern_list() function up
> to OpenBSD it should mean most future diffs will apply cleanly.

I'm fine with that.

-d


More information about the openssh-unix-dev mailing list