fido_init() not being called

Brian Candler b.candler at
Sun May 3 04:27:28 AEST 2020

Hello, just raising a minor issue in sk-usbhid.c

At the moment, fido_init() is not being called except when SK_DEBUG is 
enabled (which normally isn't):

#ifdef SK_DEBUG

That exists in two places.  I mentioned this in passing on the libfido2 
tracker and the response is:

"Regarding OpenSSH and fido_init(), OpenSSH should be calling 
fido_init(). There are currently no ill effects from not calling it, but 
that might change in the future."

So I'd suggest changing to something like:

#ifdef SK_DEBUG

- or define a new macro with value 0 or FIDO_DEBUG as appropriate.



More information about the openssh-unix-dev mailing list