Restoring block mode on exiting

Dmitry Belyavskiy dbelyavs at redhat.com
Mon Apr 26 17:34:37 AEST 2021


Hi David,

On Mon, Apr 26, 2021 at 1:59 AM David Newall <openssh at davidnewall.com>
wrote:

> Hi Dmitry,
> On 25/4/21 6:23 pm, Dmitry Belyavskiy wrote:
>
> Yes, generally right, but, I feel you've assumed that the files are
> initially
> blocking which is not necessarily so.
>
>
> I think I don't - see the lines 341-354 of the channels.c in the proposed
> patch
>
> I do beg your pardon, you are right.  The patch looks okay to me.
>

Many thanks for the review!
The clarification comment is pushed.

-- 
Dmitry Belyavskiy


More information about the openssh-unix-dev mailing list