[PATCH] do not free string returned by login_getcapstr
emaste at freebsd.org
Wed Feb 17 02:18:58 AEDT 2021
On Mon, 15 Feb 2021 at 18:58, Damien Miller <djm at mindrot.org> wrote:
> > NetBSD is idential to OpenBSD. I guess we'll need to special-case FreeBSD
> > and anything else that derives from that codebase. Does anyone know what
> > else does it the FreeBSD way? (I'm guessing Dragonfly...)
I'd assume MidnightBSD as another reply suggested.
> actually, this is in the child process so the leak doesn't matter here.
> I think this fix is fine.
That sounds reasonable to me. Probably with a comment pointing out
that we're intentionally ignoring the leak due to OS differences as a
hint to folks looking at static analysis results in the future. (While
looking at this issue on FreeBSD I saw that Coverity has a false
positive flagging it as a leak.)
More information about the openssh-unix-dev