[PATCH 1/2] Indent code before next channge

David Newall openssh at davidnewall.com
Wed Jun 30 15:12:09 AEST 2021


On 30/6/21 5:42 am, list at johnericson.me wrote:
> From: John Ericson <John.Ericson at Obsidian.Systems>
>
> This hopefully makes for a better diff.
> ---
>   configure.ac | 136 +++++++++++++++++++++++++--------------------------
>   1 file changed, 68 insertions(+), 68 deletions(-)

I rely on diff to see what is different between two versions, and not 
necessarily
consecutive versions.  It is an immensely effective technique for 
finding where
something became broken.

Diffs like that which John proposes add noise, dramatically increasing 
the effort
required to see real changes.  Did he simply change indent or did he 
also change
text?  I can't tell at a glance.

I request that his diff be rejected.


More information about the openssh-unix-dev mailing list