OS X poll breakage (Was: Please help test recent changes)

[Darren Tucker]

On Fri, Jan 07, 2022 at 09:52:09AM +1100, Damien Miller wrote:
> 1. Conversion of the ssh and sshd mainloop from select() to poll()
> 
> This should be entirely invisible to users, so any behaviour change
> is a bug. If you see something and want to help debug it further,
> uncomment the DEBUG_CHANNEL_POLL #define in channels.c for helps of
> extra debug logging.

This change breaks (at least) the exit-status test on Mac OS X.  I
haven't had a chance to investigate yet,

$ git bisect run sh -c "autoreconf && ./configure --without-openssl &&
make t-exec LTESTS=exit-status"
[... lots ...]
17877bc81db3846e6e7d4cfb124d966bb9c9296b is the first bad commit
commit 17877bc81db3846e6e7d4cfb124d966bb9c9296b
Author: djm at openbsd.org <djm at openbsd.org>
Date:   Thu Jan 6 21:48:38 2022 +0000

    upstream: convert ssh, sshd mainloops from select() to poll();

    feedback & ok deraadt@ and markus@ has been in snaps for a few months

    OpenBSD-Commit-ID: a77e16a667d5b194dcdb3b76308b8bba7fa7239c

$ uname -a
Darwin osx-highsierra 17.7.0 Darwin Kernel Version 17.7.0: Fri Oct 30
13:34:27 PDT 2020; root:xnu-4570.71.82.8~1/RELEASE_X86_64 x86_64

-- 
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860  37F4 9357 ECEF 11EA A6FA (new)
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.