[PATCH] Include fix

Thomas Köller thomas at koeller.dyndns.org
Sat Jan 29 03:54:57 AEDT 2022


Am 27.01.22 um 23:24 schrieb Darren Tucker:
 > For this specific diff: in most cases we put the required includes in 
the .c file.   Is there some case where your change is needed to compile?

Yes, of course. It is the auth.h header itself that uses a typedef 
(HostStatus) from hostfile.h, so including just auth.h without prior 
inclusion of hostfile.h leads to a compilation error. That's what the 
patch comment tries to express...

I came across this (and the problem addressed by the other patch I 
submitted today, which is very similar) writing an extension to sshd 
(which I plan to propose when it's ready). This extension adds some new 
.c files, and there the two problems surfaced.


More information about the openssh-unix-dev mailing list