[PATCH] Improve endian conversion in umac.c

[Chris Rapier]

Haven't checked that yet but I'll look into it tomorrow.

On Tue, Mar 8, 2022, 18:13 Darren Tucker <dtucker at dtucker.net> wrote:

> On Wed, 9 Mar 2022 at 09:59, rapier <rapier at psc.edu> wrote:
> > I was poking at the MAC routines looking for some efficiencies for high
> > performance environments. I was looking at the umac.c and comparing it
> > to the original source at https://fastcrypto.org/front/umac/umac.c After
> > a couple of false starts I found that reverting the endian conversion
> > routines back to what Krovetz wrote realized a 8% to 16% improvement
>
> Interesting!  One obvious difference is what you have is potentially
> inline-able static functions instead of function calls across
> compilation units that (barring whole program optimization) can't be
> inlined.  If you put the existing functions from misc.c into umac.c as
> statics do you see the same improvement?
>
> --
> Darren Tucker (dtucker at dtucker.net)
> GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860  37F4 9357 ECEF 11EA A6FA (new)
>     Good judgement comes with experience. Unfortunately, the experience
> usually comes from bad judgement.
>