openssh portable on FreeBSD i386

[mike tancsa]

On 6/1/2023 11:47 AM, Thorsten Glaser wrote:
> On Thu, 1 Jun 2023, mike tancsa wrote:
>
>> Not sure if this is the right approach / patch, but I am able to compile
> No, I’d rather convert the known value to the type-of-unknown-signedness
> (might even be float).
>
> -                           now >= c->lastused + c->inactive_deadline) {
> +                           now >= c->lastused + (time_t)c->inactive_deadline) {
>
> In general, #ifdef i386 is wrong.

Thanks,

compile/build and run tested on FreeBSD 13 both i386 and AMD64 with the 
following patch

--- channels.c.orig     2023-06-01 15:52:19 UTC
+++ channels.c
@@ -2566,7 +2566,7 @@ channel_handler(struct ssh *ssh, int table, struct tim
                         if (table == CHAN_PRE &&
                             c->type == SSH_CHANNEL_OPEN &&
                             c->inactive_deadline != 0 && c->lastused != 
0 &&
-                           now >= c->lastused + c->inactive_deadline) {
+                           now >= c->lastused + (time_t) 
c->inactive_deadline) {
                                 /* channel closed for inactivity */
                                 verbose("channel %d: closing after %u 
seconds "
                                     "of inactivity", c->self,

     ---Mike