Large file support, mkstemp, and off_t

[Damien Miller]

On Wed, 22 Mar 2023, Allen Webb wrote:

> We are trying to enable large file support for everything built for
> ARM on ChromeOS and openssh uses mkstemp which has a 64-bit version
> for compatibility with open64. When looking into enabling the large
> file support flags, I noticed:
> 
> `void    start_progress_meter(const char *, off_t, off_t *);`
> 
> in progressmeter.h which would have different ABIs with and without
> large file support. You all probably ought to avoid exposing off_t in
> any external-facing APIs.

OpenSSH doesn't have any external-facing APIs though, we don't ship
a library for others to use. progressmeter.h is just for scp and sftp.

-d