Request information about the patch "57d10cb"

[Damien Miller]

You should switch to an OpenSSH release that was made in the past eight
years, we've made a lot of improvements since then.

I doubt you'll be able to revert that patch easily - it was part of
a major refactoring of OpenSSH and anything that touches the same
files later will likely conflict.

Finally, I don't understand how that patch could cause performance
problems - it is mostly just passing a pointer to connection state
down to functions that use it, rather than using shared state.

On Sat, 25 Mar 2023, Sam Kappen wrote:

> Could somebody explain the below patch  which is added in openssh6.8.P1?.
> During the netconf test at the end customer site it causes performance
> degradation. Would this cause any other issues if we revert this patch in
> openssh 6.8.P1?
> 
> commit 57d10cbe861a235dd269c74fb2fe248469ecee9d
> Author: markus at openbsd.org <markus at openbsd.org>
> Date:   Mon Jan 19 20:16:15 2015 +0000
> 
>     upstream commit
> 
>     adapt kex to sshbuf and struct ssh; ok djm@
> 
> Regards,
> Sam
> _______________________________________________
> openssh-unix-dev mailing list
> openssh-unix-dev at mindrot.org
> https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
>