Call for testing: openssh-10.3

[Damien Miller]

On Mon, 30 Mar 2026, Sevan Janiyan wrote:

> On 29/03/2026 06:47, Damien Miller wrote:
> > Snapshot releases for portable OpenSSH are available from
> > http://www.mindrot.org/openssh_snap/
> 
> Built fine without issue on OS X 10.4 PowerPC with GCC 4.0.1
> 
> There is a regression on OS X 10.3, build attempted with GCC 3.3 which is the
> compile it shipped with it.
> 
> (cd openbsd-compat && make)
> cc -std=gnu99 -g -O2 -pipe -Wall -Wpointer-arith -Wuninitialized
> -Wsign-compare -Wformat-security -Wno-unused-parameter -Wimplicit-fallthrough
> -fno-strict-aliasing -D_FORTIFY_SOURCE=2 -ftrapv -fno-builtin-memset   -fPIC
> -I. -I.. -I. -I./.. -I"/tmp/openssh/openbsd-compat/include"
> -I/opt/nutools/include -DOPENSSL_API_COMPAT=0x10100000L -DHAVE_CONFIG_H -c
> bsd-asprintf.c
> In file included from ../openbsd-compat/bsd-statvfs.h:24,
>                  from ../openbsd-compat/openbsd-compat.h:220,
>                  from ../includes.h:179,
>                  from bsd-asprintf.c:20:
> /usr/include/sys/mount.h:128: error: parse error before "CIRCLEQ_ENTRY"
> /usr/include/sys/mount.h:149: error: parse error before '}' token
> make[1]: *** [bsd-asprintf.o] Error 1
> make: *** [openbsd-compat/libopenbsd-compat.a] Error 2
> 
> 
> /usr/include/sys/mount.h shipped in OS X 10.3.9 which the build is complaining
> about can be found here:
> https://github.com/apple-oss-distributions/xnu/blob/xnu-517.12.7/bsd/sys/mount.h
> 
> I wondered if the COMPATINCLUDESDIR handling which has changed since 10.2
> might be the culprit but I haven't explored further yet.

I think what's happening here is that our openbsd-compat/sys-queue.h lacks
the CIRCLEQ definitions that the platform sys/mount.h needs. 

I'm not sure how best to fix this for this release, as adding CIRCLEQ
definitions to this file carries risks of its own.

A hacky solution might be to stick a:

#define CIRCLEQ_ENTRY(x) void *

in bsd-statvfs.h right before the sys/mount.h inclusion, wrapped in a
bunch of #ifdef

-d