[Bug 823] Rename fails on fat32 partitions

[bugzilla-daemon at mindrot.org]

http://bugzilla.mindrot.org/show_bug.cgi?id=823

           Summary: Rename fails on fat32 partitions
           Product: Portable OpenSSH
           Version: 3.8p1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: major
          Priority: P2
         Component: sftp-server
        AssignedTo: openssh-bugs at mindrot.org
        ReportedBy: iwish at musician.org


I have found that in the static void process_rename(void) function of
sftp-server.c when a file being renamed in Linux (and I assume all types on
UN*Xs) is mounted on a fat32 partition the rename fails.This may effect other
non-posix filesystem files as well.

I tracked the problem down to the link(oldpath, newpath) == -1) failing, since
the S_ISREG(sb.st_mode) condition is met with a fat32 mounted filesystem file. I
found that if the link() fails falling back on rename() works to remedy the
problem, but I wasn't sure if this is safe coding.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.