[Bug 1157] ssh-keygen doesn't handle DOS line breaks

bugzilla-daemon at mindrot.org bugzilla-daemon at mindrot.org
Mon Feb 27 22:47:27 EST 2006


http://bugzilla.mindrot.org/show_bug.cgi?id=1157





------- Comment #17 from dtucker at zip.com.au  2006-02-27 22:47 -------
(In reply to comment #16)
> >+	if (len > INT_MAX)
> >+		return -1;
> 
> I don't think this is necessary in the context.

I was being paranoid.

> Maybe this function should return the length of the string, that would
> save the strlen() later:

Good idea, I'll change it.

> Regress test? :)

Some people are never happy :-)  Actually I already have one but posting it as
a diff is useless because of the line-break differences in the test data.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.




More information about the openssh-bugs mailing list