[Bug 1243] Multiple including of paths.h on AIX 5.1 systems.

[bugzilla-daemon at bugzilla.mindrot.org]

http://bugzilla.mindrot.org/show_bug.cgi?id=1243


Kieron Curtis <cartmanltd at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cartmanltd at hotmail.com




--- Comment #2 from Kieron Curtis <cartmanltd at hotmail.com>  2007-05-31 17:08:35 ---
PATCH #1243: I believe this bug is due to a typo in the "includes.h"
file.

Line 52 of includes.h checks for definition of macro HAVE_PATHS when it
should in fact be checking for HAVE_PATHS_H
No-where else in the source is any reference made to the the errant
name, only the latter. Using the errant name causes the compiler to
execute the wrong order of include files and macro definitions.

Errant code in includes.h:
    ...
    #ifdef HAVE_PATHS
    # include <paths.h>
    #endif
    ...

When it should be as follows:
    ...
    #ifdef HAVE_PATHS_H
    # include <paths.h>
    #endif
    ...

This fix allows the compilation to proceed without errors.

Note 1: this problem still exists in openssh-4.6p1.

Note 2: the AIX compiler XLC V6 will cause fatal errors when macros are
redefined, whilst XLC V8 will produce warnings. Hence, using later
versions of the compiler may "hide" the problem.


-- 
Configure bugmail: http://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.