[Bug 1380] incorrect check for strlen(fwd->connect_host) in parse_forward()

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=1380





--- Comment #7 from Jan Pechanec <Jan.Pechanec at Sun.COM>  2008-07-04 20:19:10 ---
I'm wondering, after reading the forwarding section of 4254 again, is
it worth to have SSH_CHANNEL_PATH_LEN at all? 4254 talks about domain
name only, not mentioning any limitation, which implies that one should
rely on the existing spec, RFC 2181. Unless there is any need to limit
the domain name length further, which I doubt, there is no need for 2
macros.

that way, SSH_MAX_DOMAIN_LEN may be the only macro defined and used (in
the last revision of the patch, both macros are used which might be
confusing for the reader of the code).

I would also vote for defining it to 255, use str[SSH_MAX_DOMAIN_LEN +
1] for definition, and "strlen(xxx) > SSH_MAX_DOMAIN_LEN)" in
comparisons. It seems more logical and mainly, more readable. However,
that's already nit picking.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.