[Bug 1329] stale control sockets prevent connection.

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=1329

--- Comment #6 from David Woodhouse <dwmw2 at infradead.org>  ---
(In reply to comment #1)
> what about cases where the mux server has exceeded its connection
> backlog? wouldn't you end up zapping a live mux socket there?

I don't think so. In that case, you'll get a fairly long (perhaps
infinite?) timeout on connect() followed by -EAGAIN.

You could _only_ get -ECONNREFUSED if there really isn't anything
listening, I believe.

(In reply to comment #3)
> I think this approach is safer: fall back to creating a new TCP
> connection after errors in the mux client path.

The problem with this approach is that when there are stale sockets
lying around, it looks nothing will ever clean them up. So with
'ControlMaster Auto' you will keep falling back to TCP connections and
not using the mux socket (and not creating a new mux socket) for ever.

I much prefer the option of deleting the offending socket.

On the other hand, perhaps we just don't want sockets to appear in the
file system at all -- perhaps we should allow the user to use
'abstract' socket addresses.... see bug #1775.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.