[Bug 1829] auth-rsa.c: move auth_key_is_revoked() call from auth_rsa_verify_response() to auth_rsa_key_allowed()

bugzilla-daemon at bugzilla.mindrot.org bugzilla-daemon at bugzilla.mindrot.org
Wed Oct 5 02:58:46 EST 2011


--- Comment #7 from Dmitry V. Levin <ldv at altlinux.org> 2011-10-05 02:58:46 EST ---
(In reply to comment #6)
> I think the behaviour that I committed is correct: the key that is
> being matched has been confirmed as revoked, there is no point
> continuing to match

The file may still contain valid keys.
Even in case of syntax error the code just skips broken lines.

> and it's probably dangerous to do so - e.g. a
> subsequent listing of the same key will cause it to be "unrevoked"

Would it?  How a key that is already revoked could be "unrevoked"?

Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

More information about the openssh-bugs mailing list