[Bug 2319] [PATCH REVIEW] U2F authentication

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=2319

Jakub Jelen <jjelen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jjelen at redhat.com

--- Comment #13 from Jakub Jelen <jjelen at redhat.com> ---
Created attachment 2710
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2710&action=edit
patch rebased to current upstream

I did informal review of the patch from comment 4, rebased it to
current upstream version and tested with yubikey neo. It worked well
and I also like the idea. There are few things to note:

 * There is non-complete client option u2f_authentication, which is
used for allowing this type of authentication on client. This should be
covered in config parser and also documented in ssh_config (fixed)

 * Build with gssapi was failing, because of undefined symbols in
monitor_wrap.c (included from auth-u2f.c). Added missing include
ssh-gss.h. (fixed)

 * some functions from sshconnect2.c and ssh-u2f.c have wrong interface
for ssh_dispatch_set. Changing void to int and adding appropriate
return value.(fixed)

 * SSL_load_error_strings function is used, but header providing this
function is not included. Adding appropriate include. (fixed)

Still there are some TODO comments, that should be taken care of.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.