[Bug 2642] [sshconnect2] publickey authentication only properly works if used first: pubkey_prepare doesn't work after pubkey_cleanup

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=2642

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
           Assignee|unassigned-bugs at mindrot.org |djm at mindrot.org

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
Created attachment 2897
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2897&action=edit
more clear pubkey_reset()

Thanks for looking at this.

I not sure I properly understand why you change modifies id->tried. Is
it to move all tried keys to the end of the list? I think it might be
clearer to do something like the attached. It's a little longer, but
IMO easier to understand its intent.

Also, I don't understand why you reset isprivate. I think this might
cause re-prompting for passwords to load keys that have already been
loaded.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.