[Bug 2341] XQuartz X11 forwarding not working in OS X 10.10 Yosemite

bugzilla-daemon at bugzilla.mindrot.org bugzilla-daemon at bugzilla.mindrot.org
Wed Sep 7 15:36:06 AEST 2016


https://bugzilla.mindrot.org/show_bug.cgi?id=2341

--- Comment #15 from Damien Miller <djm at mindrot.org> ---
Comment on attachment 2871
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2871
OSX X11: if using launchd socket, remove the screen number

IMO this might be better off as a separate function. Also a couple of
nits:

> strlcpy(path, display, sizeof(path))

should check for truncation

The tests like (0 == stat(path, &sbuf)) are a bit unidiomatically
backwards-ordered

> +			if (dot) {

style(9) says (dot != NULL)

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.


More information about the openssh-bugs mailing list