[Bug 2687] Coverity scan fixes

[bugzilla-daemon at bugzilla.mindrot.org]

https://bugzilla.mindrot.org/show_bug.cgi?id=2687

--- Comment #2 from Jakub Jelen <jjelen at redhat.com> ---
Created attachment 2954
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2954&action=edit
2nd part with lower priority

few more reports with lower priority and confidence of the need to be
fixed:

krl.c
 * RESOURCE_LEAK: Overwriting "sect" in "sect = NULL" leaks the storage
that "sect" points to.
 * NEGATIVE_RETURNS: "fd" is passed to a parameter that cannot be
negative in case the open() fails.

readconf.c
servconf.c
 * REVERSE_INULL: bogus NULL checks (can't be NULL in any of the cases)

ssh-pkcs11.c
 * NULL_RETURNS: Sanitize return value of sshkey_new()

sshconnect1.c
 * NULL_RETURNS: Sanitize return value of sshkey_new()

sshkey.c
 * NULL_RETURNS: Directly dereferencing parameter "ret".

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.