[Bug 3190] Inconsistent handling of private keys without accompanying public keys

bugzilla-daemon at mindrot.org bugzilla-daemon at mindrot.org
Fri Jul 3 04:35:44 AEST 2020


https://bugzilla.mindrot.org/show_bug.cgi?id=3190

Jakub Jelen <jjelen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3424|                            |ok?
              Flags|                            |

--- Comment #1 from Jakub Jelen <jjelen at redhat.com> ---
Created attachment 3424
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3424&action=edit
Proposed patch to fall back to alternative methods of getting public
key

It turned out that initial solution is as easy as fixing the logic in
the conditions (see attached patch).

In this function we need to return (goto out) in case we found the key,
not the other way round.

As this code was recently written by Damien, I added him for review.

With the attached patch, keys in openssh format seems to work
correctly. If there would not be anything against, I would like to have
a look also to normal non-encrypted PEM files to take similar approach
and probably add some regression test case to keep this working.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.


More information about the openssh-bugs mailing list