Bug fix -- version grepping in compat.c

Markus Friedl Markus.Friedl at informatik.uni-erlangen.de
Sat Dec 2 09:44:35 EST 2000


the "no match" message is no warning.

it's a debug message: "debug: no match: OpenSSH_2.3.0p1"

it informs you that there is no known interoperability bug
for version OpenSSH_2.3.0


On Fri, Dec 01, 2000 at 04:15:15PM -0600, Hamon, Brian K. wrote:
> I beg your pardon. The problem was definitely on my end and was unrelated 
> to the regular expression I modified. Rebuilding fixed my core dump. I 
> still note a minor issue, which may possibly have some impact.
> 
> When connecting between two OpenSSH-2.3.0 implementations as follows:
> 
> ssh -2 -v host
> 
> The debug output contains a "no match" warning:
> 
> debug: Connection established.
> debug: Remote protocol version 1.99, remote software version OpenSSH_2.3.0p1
> debug: no match: OpenSSH_2.3.0p1
> Enabling compatibility mode for protocol 2.0
> 
> Is the "no match" warning worth addressing? Probably not. I made the change 
> in the regular expression and the warning went away. The difference this 
> change makes is whether the SSH_OLD_SESSIONID bug fix is applied. This 
> appears to be irrelevant.

2.3.0 does not have the SSH_OLD_SESSIONID bug.

> The "no match" warning could be considered unexpected behavior, but appears 
> to have no consequences.

no, it's not a warning. i cannot see what makes it look
like a warning.

> 
> >what bug does your suggestion fix?
> >what bug do you see? there is not bug to fix.
> >
> >
> >On Fri, Dec 01, 2000 at 03:39:46PM -0600, Hamon, Brian K. wrote:
> > > In OpenSSH-2.3.0, in the file ssh/compat.c, line 61 the line:
> > >
> > >        { "^OpenSSH[-_]2\\.[012]", SSH_OLD_SESSIONID },
> > >
> > > Will not match another OpenSSH-2.3.0 client. The quick fix is to add 
> > "3" to
> > > the regular expression as follows:
> > >
> > >        { "^OpenSSH[-_]2\\.[0123]", SSH_OLD_SESSIONID },
> > >
> > > The same bug is in the portable release, but the line number is 65.
> > >
> > >
> 
> 





More information about the openssh-unix-dev mailing list